On 09/26/2013 07:20 AM, Andi Kleen wrote: > On Wed, Sep 25, 2013 at 06:21:29PM -0700, Andrew Morton wrote: >> On Wed, 25 Sep 2013 18:15:21 -0700 Arjan van de Ven <arjan@xxxxxxxxxxxxxxx> wrote: >> >>> On 9/25/2013 4:47 PM, Andi Kleen wrote: >>>>> Also, the changelogs don't appear to discuss one obvious downside: the >>>>> latency incurred in bringing a bank out of one of the low-power states >>>>> and back into full operation. Please do discuss and quantify that to >>>>> the best of your knowledge. >>>> >>>> On Sandy Bridge the memry wakeup overhead is really small. It's on by default >>>> in most setups today. >>> >>> btw note that those kind of memory power savings are content-preserving, >>> so likely a whole chunk of these patches is not actually needed on SNB >>> (or anything else Intel sells or sold) >> >> (head spinning a bit). Could you please expand on this rather a lot? > > As far as I understand there is a range of aggressiveness. You could > just group memory a bit better (assuming you can sufficiently predict > the future or have some interface to let someone tell you about it). > > Or you can actually move memory around later to get as low footprint > as possible. > > This patchkit seems to do both, with the later parts being on the > aggressive side (move things around) > Yes, that's correct. Grouping memory at allocation time is achieved using 2 techniques: - Sorted-buddy allocator (patches 1-15) - Split-allocator design or a "Region Allocator" as back-end (patches 16-33) The aggressive/opportunistic page movement or reclaim is achieved using: - Targeted region evacuation mechanism (patches 34-40) Apart from being individually beneficial, the first 2 techniques influence the Linux MM in such a way that it tremendously improves the yield/benefit of the targeted compaction as well :-) [ Its due to the avoidance of fragmentation of allocations pertaining to _different_ migratetypes within a single memory region. By keeping each memory region homogeneous with respect to the type of allocation, targeted compaction becomes much more effective, since for example, we won't have cases where a stubborn unmovable page will end up disrupting the region-evac attempt of a region which has mostly movable/reclaimable allocations. ] > If you had non content preserving memory saving you would > need to be aggressive as you couldn't afford any mistakes. > > If you had very slow wakeup you also couldn't afford mistakes, > as those could cost a lot of time. > > On SandyBridge is not slow and it's preserving, so some mistakes are ok. > > But being aggressive (so move things around) may still help you saving > more power -- i guess only benchmarks can tell. It's a trade off between > potential gain and potential worse case performance regression. > It may also depend on the workload. > True, but we get better consolidation ratios than mainline even without getting too aggressive. For example, the v3 of this patchset didn't have the targeted compaction logic, and still it was able to show up to around 120 free-regions at the end of test run. http://article.gmane.org/gmane.linux.kernel.mm/106283 This version of the patchset with the added aggressive logic (targeted compaction) makes it only better: the free-regions number comes up to 202. > At least right now the numbers seem to be positive. > :-) Regards, Srivatsa S. Bhat -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>