Hi Christoph, On Thu, Oct 25, 2012 at 03:19:27PM +0000, Christoph Lameter wrote: > On Thu, 25 Oct 2012, Minchan Kim wrote: > > > #endif > > + /* > > + * True if page in this vma is reclaimed. > > What does that mean? All pages in the vma have been cleared out? It means at least, more than one is reclaimed. Comment should have been cleared. > > > + TTU_IGNORE_VOLATILE = (1 << 11),/* ignore volatile */ > > }; > > #define TTU_ACTION(x) ((x) & TTU_ACTION_MASK) > > > > int try_to_unmap(struct page *, enum ttu_flags flags); > > int try_to_unmap_one(struct page *, struct vm_area_struct *, > > - unsigned long address, enum ttu_flags flags); > > + unsigned long address, enum ttu_flags flags, > > + bool *is_volatile); > > You already pass a vma pointer in. Why do you need to pass a > volatile flag in? Looks like unecessary churn. You mean we can use vma->purged instead of is_volatile passing? The is_volatile is just checking for that all of vmas share the page are volatile ones. Then, vma->purged is just checking for that the page is zapped in the vma. If one of vma share the page isn't volatile, we can't zap. BTW, Christoph, what do you think about the goal of the patch which changes munmap(2) to madvise(2) when user calls free(3) in user allocator like glibc? I guess it would improve system performance very well. But as I wrote down in description, downside of the patch is that we have to age anon lru although we don't have swap. But gain via the patch is bigger than loss via aging of anon lru when memory pressure happens. I don't see other downside other than it. What do you think about it? (I didn't implement anon lru aging in case of no-swap but it's trivial once we decide) Thanks for the review, Christoph > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@xxxxxxxxx. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a> -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>