On Thu, 25 Oct 2012, Minchan Kim wrote: > #endif > + /* > + * True if page in this vma is reclaimed. What does that mean? All pages in the vma have been cleared out? > + TTU_IGNORE_VOLATILE = (1 << 11),/* ignore volatile */ > }; > #define TTU_ACTION(x) ((x) & TTU_ACTION_MASK) > > int try_to_unmap(struct page *, enum ttu_flags flags); > int try_to_unmap_one(struct page *, struct vm_area_struct *, > - unsigned long address, enum ttu_flags flags); > + unsigned long address, enum ttu_flags flags, > + bool *is_volatile); You already pass a vma pointer in. Why do you need to pass a volatile flag in? Looks like unecessary churn. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>