Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 19, 2024 at 9:45 PM Michal Hocko <mhocko@xxxxxxxx> wrote:
>
> On Fri 19-07-24 21:36:38, Barry Song wrote:
> > And I believe that even most MM experts have no idea when GFP_NOFAIL
> > will fail. This is so bad to keep it as is.
>
> GFP_NOFAIL doesn't fail in any supported scenarios. We are talking how
> to deal with those that are unsupported. I am not sure how much helpful
> it is to document all potential gfp combinations that make no-sense.

Sorry, I don't see any point from what you are saying. You are simply claiming
this is the fault of those calling "unsupported" APIs while lacking a valid way
to stop this from happening. Bear in mind, Everything which is not forbidden
is allowed.

I don't think maintainers  outside mm know what are supported and what
are not supported. an "unsupported" scenario can find a way to come into
mainline easily.

> --
> Michal Hocko
> SUSE Labs

Thanks
Barry





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux