Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Barry Song <21cnbao@xxxxxxxxx>
Subject: Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
From: Michal Hocko <mhocko@xxxxxxxx>
Date: Fri, 19 Jul 2024 11:45:26 +0200
Cc: akpm@xxxxxxxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, Barry Song <v-songbaohua@xxxxxxxx>, Uladzislau Rezki <urezki@xxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Lorenzo Stoakes <lstoakes@xxxxxxxxx>, Christoph Lameter <cl@xxxxxxxxx>, Pekka Enberg <penberg@xxxxxxxxxx>, David Rientjes <rientjes@xxxxxxxxxx>, Joonsoo Kim <iamjoonsoo.kim@xxxxxxx>, Vlastimil Babka <vbabka@xxxxxxx>, Roman Gushchin <roman.gushchin@xxxxxxxxx>, Hyeonggon Yoo <42.hyeyoo@xxxxxxxxx>
In-reply-to: <CAGsJ_4zKEZeoFHzNevfVQeNgVhW=Bf3DyBxGpyNYVgQvpUHKig@mail.gmail.com>
References: <ZpjXacbUGxTs9cR0@tiehlicka> <CAGsJ_4wNre89_pQWvU0jj6reLaETYOTUVu3DYwPo8Up1DM1-8A@mail.gmail.com> <ZpoPafjDrA4T_o0y@tiehlicka> <CAGsJ_4wbvNxDOYx0RNQd0vaH5KScPdJFvdi9SWkXVRF_41cVXA@mail.gmail.com> <ZpoYyp8aHWGyCK-8@tiehlicka> <CAGsJ_4xpLf6qfvfNmowT01xF8ETBPM46-A=3umHEUXpk=fQ04A@mail.gmail.com> <ZpodRShdeVsFu_mH@tiehlicka> <CAGsJ_4zQZ=K4j4RzRZXd7LENCru72+FO2BjjJw2LS87rG5KR3Q@mail.gmail.com> <ZpomZ03Szp32aA-2@tiehlicka> <CAGsJ_4zKEZeoFHzNevfVQeNgVhW=Bf3DyBxGpyNYVgQvpUHKig@mail.gmail.com>

On Fri 19-07-24 21:36:38, Barry Song wrote:
> And I believe that even most MM experts have no idea when GFP_NOFAIL
> will fail. This is so bad to keep it as is.

GFP_NOFAIL doesn't fail in any supported scenarios. We are talking how
to deal with those that are unsupported. I am not sure how much helpful
it is to document all potential gfp combinations that make no-sense. 
-- 
Michal Hocko
SUSE Labs

Follow-Ups:
- Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
  - From: Barry Song

References:
- Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
  - From: Michal Hocko
- Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
  - From: Barry Song
- Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
  - From: Michal Hocko
- Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
  - From: Barry Song
- Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
  - From: Michal Hocko
- Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
  - From: Barry Song
- Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
  - From: Michal Hocko
- Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
  - From: Barry Song
- Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
  - From: Michal Hocko
- Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
  - From: Barry Song

Prev by Date: [RFC v11 13/14] mm: page_frag: update documentation for page_frag
Next by Date: [RFC v11 11/14] mm: page_frag: introduce prepare/probe/commit API
Previous by thread: Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
Next by thread: Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]