Re: [PATCH] mm: remove partial comments of kswapd_shrink_node head

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 25 Jun 2024 20:15:47 +0800 "yongfa.hu" <hushange@xxxxxxx> wrote:

> when function kswapd_shrink_node return, it will not check the condition
> mentioned in the removed comments: "if the lack of progress was
> due to pages under writeback", so remove it.

Is this correct?  shrink_folio_list() can skip under-writeback pages?


> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -6747,8 +6747,7 @@ static bool prepare_kswapd_sleep(pg_data_t *pgdat, int order,
>   * zone that is currently unbalanced.
>   *
>   * Returns true if kswapd scanned at least the requested number of pages to
> - * reclaim or if the lack of progress was due to pages under writeback.
> - * This is used to determine if the scanning priority needs to be raised.
> + * reclaim. This is used to determine if the scanning priority needs to be raised.
>   */
>  static bool kswapd_shrink_node(pg_data_t *pgdat,
>  			       struct scan_control *sc)
> -- 
> 2.17.1




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux