You've not cc'd the vmalloc reviewers, including the author of 3e9a9e256b1e
whose patch you purport to fix. Please remember to run get_maintainers.pl
on all files you patch and cc them at least on relevant patches.
Have added Christoph + Uladzislau as cc.
You'll definitely want an ack from Christoph on this!
On Thu, May 11, 2023 at 02:21:09PM +0100, Ryan Roberts wrote:
> It is bad practice to directly set pte entries within a pte table.
> Instead all modifications must go through arch-provided helpers such as
> set_pte_at() to give the arch code visibility and allow it to validate
> (and potentially modify) the operation.
This does make sense, and I see for example in xtensa that an arch-specific
instruction is issued under certain circumstances so I do suspect we should
do this.
As for validation, the function never indicates an error, so only in the
sense that a WARN_ON() could _in theory_ trigger is it being
validated. This might be quite a nitty point :) as set_pte_at() has no
means of indicating an error. But maybe to be pedantic 'check' rather than
'validate'?
>
> Fixes: 3e9a9e256b1e ("mm: add a vmap_pfn function")
Not sure if this is really 'fixing' anything, I mean ostensibly, but not
sure if the tag is relevant here, that is more so for a bug being
introduced, and unless an issue has arisen not sure if it's
appropriate. But this might be a nit, again!
> Signed-off-by: Ryan Roberts <ryan.roberts@xxxxxxx>
> ---
> mm/vmalloc.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index 9683573f1225..d8d2fe797c55 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -2899,10 +2899,13 @@ struct vmap_pfn_data {
> static int vmap_pfn_apply(pte_t *pte, unsigned long addr, void *private)
> {
> struct vmap_pfn_data *data = private;
> + pte_t ptent;
>
> if (WARN_ON_ONCE(pfn_valid(data->pfns[data->idx])))
> return -EINVAL;
> - *pte = pte_mkspecial(pfn_pte(data->pfns[data->idx++], data->prot));
> +
> + ptent = pte_mkspecial(pfn_pte(data->pfns[data->idx++], data->prot));
> + set_pte_at(&init_mm, addr, pte, ptent);
While we're refactoring, it'd be nice to stash data->pfns[data->idx] into a
local pfn variable.
> return 0;
> }
>
> --
> 2.25.1
>
