On 11/05/2023 16:00, Zi Yan wrote: > On 11 May 2023, at 9:21, Ryan Roberts wrote: > >> It is bad practice to directly set pte entries within a pte table. >> Instead all modifications must go through arch-provided helpers such as >> set_pte_at() to give the arch code visibility and allow it to validate >> (and potentially modify) the operation. >> >> Fixes: 3e9a9e256b1e ("mm: add a vmap_pfn function") >> Signed-off-by: Ryan Roberts <ryan.roberts@xxxxxxx> >> --- >> mm/vmalloc.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> > LGTM. Reviewed-by: Zi Yan <ziy@xxxxxxxxxx> Thanks for the reviews!