On Tue, 2011-09-27 at 17:28 +0800, Michal Hocko wrote: > On Tue 27-09-11 15:23:04, Shaohua Li wrote: > [...] > > Index: linux/mm/vmscan.c > > =================================================================== > > --- linux.orig/mm/vmscan.c 2011-09-27 13:46:31.000000000 +0800 > > +++ linux/mm/vmscan.c 2011-09-27 15:09:29.000000000 +0800 > > @@ -2565,7 +2565,9 @@ loop_again: > > sc.nr_reclaimed += reclaim_state->reclaimed_slab; > > total_scanned += sc.nr_scanned; > > > > - if (nr_slab == 0 && !zone_reclaimable(zone)) > > + if (nr_slab == 0 && !zone_reclaimable(zone) && > > + !zone_watermark_ok_safe(zone, order, > > + high_wmark_pages(zone) + balance_gap, 0, 0)) > > Hardcoded ZONE_DMA for zone_watermark_ok_safe? Shouldn't this be i for > classzone_idx? i or 0 are the same here for lowmem_reserve (both have 0 value), actually a lot of code are using 0 for zone_watermark_ok Thanks, Shaohua -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>