Re: [patch 1/2]vmscan: correct all_unreclaimable for zone without lru pages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue 27-09-11 15:23:04, Shaohua Li wrote:
[...]
> Index: linux/mm/vmscan.c
> ===================================================================
> --- linux.orig/mm/vmscan.c	2011-09-27 13:46:31.000000000 +0800
> +++ linux/mm/vmscan.c	2011-09-27 15:09:29.000000000 +0800
> @@ -2565,7 +2565,9 @@ loop_again:
>  				sc.nr_reclaimed += reclaim_state->reclaimed_slab;
>  				total_scanned += sc.nr_scanned;
>  
> -				if (nr_slab == 0 && !zone_reclaimable(zone))
> +				if (nr_slab == 0 && !zone_reclaimable(zone) &&
> +				    !zone_watermark_ok_safe(zone, order,
> +				    high_wmark_pages(zone) + balance_gap, 0, 0))

Hardcoded ZONE_DMA for zone_watermark_ok_safe? Shouldn't this be i for
classzone_idx?

>  					zone->all_unreclaimable = 1;
>  			}
>  

-- 
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9    
Czech Republic

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]