On Thu 11-08-11 15:12:45, Michal Marek wrote: > On 11.8.2011 15:01, Michal Hocko wrote: > > On Thu 11-08-11 14:51:33, Michal Hocko wrote: > >> On Wed 10-08-11 17:12:40, Michal Marek wrote: > >>> Introduced in 3.1-rc1, IS_ENABLED(CONFIG_NUMA) expands to a true value > >>> iff CONFIG_NUMA is set. This makes it easier to grep for code that > >>> depends on CONFIG_NUMA. > > > > I have just looked closer at all available macros. Wouldn't it make more > > sense to use IS_BUILTIN instead? Both symbols can be only on or off. > > Not that it would make any difference in the end. I even like IS_ENABLED > > naming more. > > IS_ENABLED() and IS_BUILTIN() are equivalent for boolean symbols. > IS_BUILTIN() and IS_MODULE() are meant for the (rare) case when someone > needs to distinguish between built in and module for tristate options in > the code. Makes sense. Thanks for the clarification. > > Michal -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>