On Wed, Mar 18, 2020 at 03:57:01PM -0700, Dan Williams wrote: > On Wed, Mar 18, 2020 at 3:49 PM George Spelvin <lkml@xxxxxxx> wrote: >> Since there's only one call site, should the function be moved to >> page_alloc.c and inlined? > > The intent was to make it compile-away on > CONFIG_SHUFFLE_PAGE_ALLOCATOR=n builds. However, > CONFIG_SHUFFLE_PAGE_ALLOCATOR=y is now the common case for distros. > So, it's not serving much purpose being in mm/shuffle.c. I'd support > moving it. The options are to define it as an inline function in shuffle.h, which keeps the #ifdef localized, or to drop it into page_alloc.c, which shrinks the shuffle.h interface but requires an #ifdef in page_alloc.h. Um... or does it? If is_shuffle_order always returns false, shuffle_pick_tail is dead code and will be elided by the compiler. But will the static variable be elided, too? Need to check.
