On Wed, Mar 18, 2020 at 02:34:04PM -0700, Alexander Duyck wrote: > What kernel is this based on? You might want to rebase on the latest > linux-next as it occurs to me that this function was renamed to > shuffle_pick_tail as I had incorporated a few bits of it into the > logic for placing buddy pages and reported pages on the tail of the > list. 5.5.8. I didn't realize it made much difference, but I see it does. Due to the different return type, the best variant has probably changed and I'll have to re-check. Since there's only one call site, should the function be moved to page_alloc.c and inlined?