On Mon, Mar 16, 2020 at 02:53:06PM +0100, Christoph Hellwig wrote: > All callers of hmm_range_fault depend on CONFIG_HMM_MIRROR, so > don't bother with a stub. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > --- > include/linux/hmm.h | 7 ------- > 1 file changed, 7 deletions(-) I agree, there is no reason not to just enable CONFIG_HMM_MIRROR if code calls it. Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxxxx> Arguably at this point the config should be renamed to CONFIG_HMM_RANGE_FAULT as all it does now is enable compiling this code, there is no runtime cost or downside to enabling it. Jason