On Mon, Mar 16, 2020 at 01:41:10PM -0300, Jason Gunthorpe wrote: > > +out_error: > > + pfns[i] = range->values[HMM_PFN_ERROR]; > > + return -EFAULT; > > I've also got a patch deleting these confusing HMM_PFN_ERRORs. They > are not applied consistently and no caller would scan the output for > ERROR on some failures. For instance the above doesn't set it on EPERM. > > So this can just be 'return -EFAULT' instead of 'goto out_error' > > I can fold that in if you agree: If you want to fix this up and the other ->pfns initialization feel free. Otherwise I'd be happy to resend.
