On 16 Mar 2020, at 9:53, Christoph Hellwig wrote:
> All callers of hmm_range_fault depend on CONFIG_HMM_MIRROR, so
> don't bother with a stub.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
> include/linux/hmm.h | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/include/linux/hmm.h b/include/linux/hmm.h
> index ddf9f7144c43..c102e359b59d 100644
> --- a/include/linux/hmm.h
> +++ b/include/linux/hmm.h
> @@ -225,17 +225,10 @@ static inline uint64_t hmm_device_entry_from_pfn(const struct hmm_range *range,
> /* Don't fault in missing PTEs, just snapshot the current state. */
> #define HMM_FAULT_SNAPSHOT (1 << 1)
>
> -#ifdef CONFIG_HMM_MIRROR
> /*
> * Please see Documentation/vm/hmm.rst for how to use the range API.
> */
> long hmm_range_fault(struct hmm_range *range, unsigned int flags);
> -#else
> -static inline long hmm_range_fault(struct hmm_range *range, unsigned int flags)
> -{
> - return -EOPNOTSUPP;
> -}
> -#endif
>
> /*
> * HMM_RANGE_DEFAULT_TIMEOUT - default timeout (ms) when waiting for a range
> --
> 2.24.1
LGTM. It compiles with and without CONFIG_HMM_MIRROR.
Reviewed-by: Zi Yan <ziy@xxxxxxxxxx>
—
Best Regards,
Yan Zi
Attachment:
signature.asc
Description: OpenPGP digital signature
