On 2019/10/30 5:36, Andrew Morton wrote: > On Tue, 29 Oct 2019 19:31:27 +0800 zhong jiang <zhongjiang@xxxxxxxxxx> wrote: > >> It is more clear to use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs >> file operation rather than DEFINE_SIMPLE_ATTRIBUTE. > hm, they do appear to be identical. It seems to DEFINE_DEBUGFS_ATTRIBUTE is special part of DEFINE_SIMPLE_ATTRUBUTE. Defined file operation is different. but use DEFINE_DEBUGFS_ATTRIBUTE to define normal fops also feasible. > Perhaps DEFINE_DEBUGFS_ATTRIBUTE shouldn't exist, or should be #defined > onto DEFINE_SIMPLE_ATTRIBUTE? > > > . Debugfs fops has an long existing in kernel. And file read and write has different implementation. I tend to keep in the way it was. Thanks, zhong jiang >
