On Tue, 29 Oct 2019 19:31:27 +0800 zhong jiang <zhongjiang@xxxxxxxxxx> wrote: > It is more clear to use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs > file operation rather than DEFINE_SIMPLE_ATTRIBUTE. hm, they do appear to be identical. Perhaps DEFINE_DEBUGFS_ATTRIBUTE shouldn't exist, or should be #defined onto DEFINE_SIMPLE_ATTRIBUTE?