On 02.08.2018 20:26, Yang Shi wrote: > On Thu, Aug 2, 2018 at 9:54 AM, Shakeel Butt <shakeelb@xxxxxxxxxx> wrote: >> On Thu, Aug 2, 2018 at 9:47 AM Yang Shi <shy828301@xxxxxxxxx> wrote: >>> >>> On Thu, Aug 2, 2018 at 4:00 AM, Kirill Tkhai <ktkhai@xxxxxxxxxxxxx> wrote: >>>> In case of shrink_slab_memcg() we do not zero nid, when shrinker >>>> is not numa-aware. This is not a real problem, since currently >>>> all memcg-aware shrinkers are numa-aware too (we have two: >>> >>> Actually, this is not true. huge_zero_page_shrinker is NOT numa-aware. >>> deferred_split_shrinker is numa-aware. >>> >> >> But both huge_zero_page_shrinker and huge_zero_page_shrinker are not >> memcg-aware shrinkers. I think Kirill is saying all memcg-aware >> shrinkers are also numa-aware shrinkers. > > Aha, thanks for reminding. Yes, I missed that memcg-aware part. Yes, I mean workingset_shadow_shrinker.
