Hi, On Mon, Jul 02, 2018 at 11:32:55AM -0600, Jonathan Corbet wrote: > On Sat, 30 Jun 2018 17:54:55 +0300 > Mike Rapoport <rppt@xxxxxxxxxxxxxxxxxx> wrote: > > > Both bootmem and memblock have pretty good documentation coverage. With > > some fixups and additions we get a nice overall description. > > > > v2 changes: > > * address Randy's comments > > > > Mike Rapoport (11): > > mm/bootmem: drop duplicated kernel-doc comments > > docs/mm: nobootmem: fixup kernel-doc comments > > docs/mm: bootmem: fix kernel-doc warnings > > docs/mm: bootmem: add kernel-doc description of 'struct bootmem_data' > > docs/mm: bootmem: add overview documentation > > mm/memblock: add a name for memblock flags enumeration > > docs/mm: memblock: update kernel-doc comments > > docs/mm: memblock: add kernel-doc comments for memblock_add[_node] > > docs/mm: memblock: add kernel-doc description for memblock types > > docs/mm: memblock: add overview documentation > > docs/mm: add description of boot time memory management > > So this seems like good stuff overall. It digs pretty deeply into the mm > code, though, so I'm a little reluctant to apply it without an ack from an > mm developer. Alternatively, I'm happy to step back if Andrew wants to > pick the set up. Jon, does Michal's reply [1] address your concerns? Or should I respin and ask Andrew to pick it up? [1] https://lore.kernel.org/lkml/20180712080006.GA328@xxxxxxxxxxxxxx/ > Thanks, > > jon > -- Sincerely yours, Mike.