On 2017/12/20 18:25, Michal Hocko wrote: > On Wed 20-12-17 18:16:53, Sergey Senozhatsky wrote: >> On (12/20/17 10:08), Michal Hocko wrote: >> [..] >>>> let's keep void zs_register_shrinker() and just suppress the >>>> register_shrinker() must_check warning. >>> >>> I would just hope we simply drop the must_check nonsense. >> >> agreed. given that unregister_shrinker() does not oops anymore, >> enforcing that check does not make that much sense. > > Well, the registration failure is a failure like any others. Ignoring > the failure can have bad influence on the overal system behavior but > that is no different from thousands of other functions. must_check is an > overreaction here IMHO. > I don't think that must_check is an overreaction. As of linux-next-20171218, no patch is available for 10 locations. drivers/staging/android/ion/ion_heap.c:306: register_shrinker(&heap->shrinker); drivers/staging/android/ashmem.c:857: register_shrinker(&ashmem_shrinker); drivers/gpu/drm/ttm/ttm_page_alloc_dma.c:1185: register_shrinker(&manager->mm_shrink); drivers/gpu/drm/ttm/ttm_page_alloc.c:484: register_shrinker(&manager->mm_shrink); drivers/gpu/drm/i915/i915_gem_shrinker.c:508: WARN_ON(register_shrinker(&i915->mm.shrinker)); drivers/gpu/drm/msm/msm_gem_shrinker.c:154: WARN_ON(register_shrinker(&priv->shrinker)); drivers/md/dm-bufio.c:1756: register_shrinker(&c->shrinker); drivers/android/binder_alloc.c:1012: register_shrinker(&binder_shrinker); arch/x86/kvm/mmu.c:5485: register_shrinker(&mmu_shrinker); fs/xfs/xfs_qm.c:698: register_shrinker(&qinf->qi_shrinker); We have out of tree modules. And as a troubleshooting staff at a support center, I want to be able to identify the careless module. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
