On Wed 20-12-17 18:16:53, Sergey Senozhatsky wrote: > On (12/20/17 10:08), Michal Hocko wrote: > [..] > > > let's keep void zs_register_shrinker() and just suppress the > > > register_shrinker() must_check warning. > > > > I would just hope we simply drop the must_check nonsense. > > agreed. given that unregister_shrinker() does not oops anymore, > enforcing that check does not make that much sense. Well, the registration failure is a failure like any others. Ignoring the failure can have bad influence on the overal system behavior but that is no different from thousands of other functions. must_check is an overreaction here IMHO. -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
