On 12/20/2017 10:15 AM, Sergey Senozhatsky wrote:
>
> On (12/19/17 15:27), Andrew Morton wrote:
> > I did this:
> >
> > From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> > Subject: mm-zsmalloc-simplify-shrinker-init-destroy-fix
> >
> > update comment (Aliaksei), make zs_register_shrinker() return void
> >
> > Cc: Aliaksei Karaliou <akaraliou.dev@xxxxxxxxx>
> > Cc: Michal Hocko <mhocko@xxxxxxxxxx>
> > Cc: Minchan Kim <minchan@xxxxxxxxxx>
> > Cc: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx>
> > Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
>
> looks good. thanks!
>
> -ss
Thanks for updating the code, Andrew, but removing return from
zs_register_shrinker() leads to triggering of 'warn_unused_result'
from 'sparse' on the line where register_shrinker() is called
(which was recently marker as __must_check).
May we leave previous variant to avoid that ? Or it is not critical ?
Best regards,
Aliaksei.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
