On Thu, 19 Aug 2010, David Rientjes wrote:
> Since sysfs_slab_add() has been removed for kmem_cache and kmem_cache_node
> here, they apparently don't need the __SYSFS_ADD_DEFERRED flag even though
> we're waiting for the sysfs initcall since there's nothing that checks for
> it. That bit can be removed, the last users of it were the dynamic DMA
> cache support that was dropped in patch 2.
Correct. Then we also do not need the sysfs_slab_add in
create_kmalloc_cache.
Signed-off-by: Christoph Lameter <cl@xxxxxxxxx>
---
mm/slub.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
Index: linux-2.6/mm/slub.c
===================================================================
--- linux-2.6.orig/mm/slub.c 2010-08-19 16:28:40.000000000 -0500
+++ linux-2.6/mm/slub.c 2010-08-19 16:30:39.000000000 -0500
@@ -148,7 +148,6 @@ static inline int kmem_cache_debug(struc
/* Internal SLUB flags */
#define __OBJECT_POISON 0x80000000UL /* Poison object */
-#define __SYSFS_ADD_DEFERRED 0x40000000UL /* Not yet visible via sysfs */
#define __ALIEN_CACHE 0x20000000UL /* Slab has alien caches */
static inline int aliens(struct kmem_cache *s)
@@ -3123,9 +3122,7 @@ static struct kmem_cache *__init create_
goto panic;
list_add(&s->list, &slab_caches);
-
- if (!sysfs_slab_add(s))
- return s;
+ return s;
panic:
panic("Creation of kmalloc slab %s size=%d failed.\n", name, size);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxxx For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>