Re: [PATCH 05/25] lmb: Factor the lowest level alloc function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 10 May 2010, Benjamin Herrenschmidt wrote:
>  
> @@ -396,33 +406,24 @@ u64 __init __lmb_alloc_base(u64 size, u64 align, u64 max_addr)
>  	if (max_addr == LMB_ALLOC_ANYWHERE)
>  		max_addr = LMB_REAL_LIMIT;
>  
> +	/* Pump up max_addr */
> +	if (max_addr == LMB_ALLOC_ANYWHERE)
> +		max_addr = ~(u64)0;
> +	

  That if is pretty useless as you set max_addr to LMB_REAL_LIMIT
  right above.

Thanks,

	tglx

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxxx  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]