On 06/01/2024 15:13, Uwe Kleine-König wrote:
> dev_err_probe() is only supposed to be used in probe functions. While it
> probably doesn't hurt, both the EPROBE_DEFER handling and calling
> device_set_deferred_probe_reason() are conceptually wrong in the request
> callback. So replace the call by dev_err() and a separate return
> statement.
>
> This effectively reverts commit c0bfe9606e03 ("pwm: jz4740: Simplify
> with dev_err_probe()").
Too much automation :(
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
Best regards,
Krzysztof
