Hello,
On Sat, Jan 06, 2024 at 06:20:44PM +0100, Krzysztof Kozlowski wrote:
> On 06/01/2024 15:13, Uwe Kleine-König wrote:
> > dev_err_probe() is only supposed to be used in probe functions. While it
> > probably doesn't hurt, both the EPROBE_DEFER handling and calling
> > device_set_deferred_probe_reason() are conceptually wrong in the request
> > callback. So replace the call by dev_err() and a separate return
> > statement.
> >
> > This effectively reverts commit c0bfe9606e03 ("pwm: jz4740: Simplify
> > with dev_err_probe()").
>
> Too much automation :(
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
I added that patch to my for-next branch at
https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/for-next
with the intention to send it for inclusion in 6.8-rc after being in
next for a few days.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
