On 21.03.2023 10:19, Krzysztof Kozlowski wrote:
On 21/03/2023 07:56, Sergio Paracuellos wrote:
On Tue, Mar 21, 2023 at 7:43 AM Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx> wrote:
On 21/03/2023 07:38, Arınç ÜNAL wrote:
Ah, but indeed there are newer Mediatek MT6xxx and MT8xxx SoCs which are
ARM, so mediatek,mtmips-sysc would work.
I can use 'mediatek,mtmips-sysc.yaml' as the name but compatibles will
start with ralink. There are already some existent compatibles for
mt762x already having ralink as prefix, so to be coherent ralink
should be maintained as prefix.
The compatibles I mentioned start already with mediatek, so why do you
want to introduce incorrect vendor name for these?
Can you point out where these compatible strings for mt7620 and mt7628 are?
git grep
Not for *-sysc nodes. The only current one in use (from git grep):
We do not talk about sysc nodes at all. They do not matter.
arch/mips/ralink/mt7620.c: rt_sysc_membase =
plat_of_remap_node("ralink,mt7620a-sysc");
That's the reason I also used prefix ralink for the rest.
Does it make sense to you to maintain this one as ralink,mt7620a-sysc
and add the following with mediatek prefix?
mediatek,mt7620-sysc
mediatek,mt7628-sysc
mediatek,mt7688-sysc
That would be weird IMHO.
What exactly would be weird? Did you read the discussion about vendor
prefix from Arinc? mt7620 is not a Ralink product, so what would be
weird is to use "ralink" vendor prefix. This was never a Ralink. However
since there are compatibles using "ralink" for non-ralink devices, we
agreed not to change them.
These though use at least in one place mediatek, so the above argument
does not apply. (and before you say "but they also use ralink and
mediatek", it does not matter - it is already inconsistent thus we can
choose whatever we want and ralink is not correct).
My argument was that your point being Ralink is now Mediatek, thus there
is no conflict and no issues with different vendor used. It's the next
best thing to be able to address the inconsistency, call everything of
the MTMIPS platform ralink on the compatible strings.
If we take the calling new things mediatek route, we will never get to
the bottom of fixing the naming inconsistency.
Arınç
