On Mon, 5 Apr 2021, Ilya Lipnitskiy wrote: > Thanks for the comments. Including asm/bugs.h in asm/mips-cps.h led to > some circular dependencies when I tried it, but I will try again based > on your feedback - indeed it would be much cleaner to have this logic > in mips_cps_numcores. The only wrinkle is that mips_cps_numcores may > return a different value on MT7621 after the cores have started due to > CPULAUNCH flags changing, but nobody calls mips_cps_numcores later > anyway, so it's a moot point today. I will clean up the change and > resend. Hmm, I don't know this system, but by the look of the code it queries launch[2], which I gather refers to the VPE #0 of an inexistent core #1, so why would the structure change given that there is no corresponding silicon? Maciej
