On 04/04/2016 02:35 PM, Jean-Michel Hautbois wrote: >>> Next, you should add a complete description to your commit. Just >>> having an object and a signed-off-by line is not enough. >> Oh, I'm sorry, I don't have any idea to explicit more details. I will >> find something for that. > > Just get the description from the datasheet as a start ;-). > >>> You also have to use the scripts/checkpatch.pl script to verify that >>> everything is ok with it. >> I have executed this script before to send it. And it noticed nothing about that. >> >>> Last thing, I can't see anything related to V4L2 in your patch. It is >>> just used to initialize the chip and the spi bus, that's all. >>> Adding a subdev is a start, and some operations if it can do something >>> else than just serializing. >> >> Maybe I'm in the wrong list for that in fact. I didn't know this list was about V4L2 and related topics. >> This driver is only to configure the component to manage the video stream in electronic card, it is not to capture video stream via V4L. >> >> I should improve my driver to be configurable by userspace. But maybe I should submit my future patch in another ML. > > Well, I am not really sure about that. I added Hans in cc as he may > have a better view. > From my point of view, it can be a V4L2 subdev, even a simple one, as > you can configure outputs, etc. I think the media subsystem is definitely the right place for this. I would use the cs3308.c driver as a starting point. This is also a minimal driver (and you can remove the code under CONFIG_VIDEO_ADV_DEBUG for your driver), but it uses v4l2_subdev and that makes it ready to be extended in the future, which you will likely need to do eventually. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
