Re: [PATCH] Add GS1662 driver (a SPI video serializer)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Le 01/04/2016 21:11, Jean-Michel Hautbois a écrit :
> Hi Charles-Antoine,
Hi,

> FIrst of all, we, on the ML, do prefer reading patches as sent by git
> send-email tool.

Ok, I will configure that.

> Next, you should add a complete description to your commit. Just
> having an object and a signed-off-by line is not enough.
Oh, I'm sorry, I don't have any idea to explicit more details. I will
find something for that.

> You also have to use the scripts/checkpatch.pl script to verify that
> everything is ok with it.
I have executed this script before to send it. And it noticed nothing about that.

> Last thing, I can't see anything related to V4L2 in your patch. It is
> just used to initialize the chip and the spi bus, that's all.
> Adding a subdev is a start, and some operations if it can do something
> else than just serializing.

Maybe I'm in the wrong list for that in fact. I didn't know this list was about V4L2 and related topics.
This driver is only to configure the component to manage the video stream in electronic card, it is not to capture video stream via V4L.

I should improve my driver to be configurable by userspace. But maybe I should submit my future patch in another ML. 

Thanks for all.
Regards,
Charles-Antoine
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux