Hi Charles-Antoine, Thank you for the patch. FIrst of all, we, on the ML, do prefer reading patches as sent by git send-email tool. It is easier to comment the patch. Next, you should add a complete description to your commit. Just having an object and a signed-off-by line is not enough. You also have to use the scripts/checkpatch.pl script to verify that everything is ok with it. Last thing, I can't see anything related to V4L2 in your patch. It is just used to initialize the chip and the spi bus, that's all. Adding a subdev is a start, and some operations if it can do something else than just serializing. That's it for the moment, when you submit a v2, I (and others) may have some more comments :). Thanks, JM 2016-04-01 18:28 GMT+02:00 Charles-Antoine Couret <charles-antoine.couret@xxxxxxxxxxxx>: > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
