Dear Kukjin, On 2015년 09월 30일 15:35, Kukjin Kim wrote: > On 09/28/15 21:02, Krzysztof Kozlowski wrote: >> W dniu 28.09.2015 o 20:54, Bartlomiej Zolnierkiewicz pisze: >>> >>> Hi, >>> >>> On Monday, September 28, 2015 05:52:13 PM Krzysztof Kozlowski wrote: >>>> W dniu 21.09.2015 o 18:59, Andrzej Pietrasiewicz pisze: >>>>> Hi Hans, >>>>> >>>>> W dniu 21.09.2015 o 11:50, Hans Verkuil pisze: >>>>>> On 18-09-15 16:21, Andrzej Pietrasiewicz wrote: >>>>>>> From: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> >>>>>>> >>>>>>> Add Exynos 5433 jpeg h/w codec node. >>>>>>> >>>>>>> Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> >>>>>>> Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@xxxxxxxxxxx> >>>>>>> --- >>>>>>> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 21 +++++++++++++++++++++ >>>>>>> 1 file changed, 21 insertions(+) >>>>>>> >>>>>>> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi >>>>>>> b/arch/arm64/boot/dts/exynos/exynos5433.dtsi >>>>>> >>>>>> This dtsi file doesn't exist in the media-git tree. What is the story >>>>>> here? >>>>>> >>>>>> Should this go through a different subsystem? >>>>>> >>>>>> I think the media subsystem can take patches 1-3 and whoever does DT >>>>>> patches can >>>>>> take this patch, right? >>>>> >>>>> The cover letter explains that the series is rebased onto Mauro's >>>>> master with Kukjin's branch merged. The latter does contain >>>>> the exynos5433.dtsi. That said, yes, taking patches 1-3 in >>>>> media subsystem and leaving DT patch to someone else is the >>>>> way to go. >>>> >>>> Although Kukjin picked Exynos 5433 ARM64 patches but they were not >>>> accepted upstream by arm-soc. He rolled it for few releases but: >>>> 1. Reason for not accepting by arm-soc was not resolved - there is no DTS. >>>> 2. Kukjin did not rebase the branch for 4.4... which maybe means that he >>>> wants to drop it? >>>> 3. Anyone (but me...) can send Galaxy Note4 (Exynos5433) DTS file based >>>> on sources on opensource.samsung.com. The DTS there is for 32-bit but it >>>> can be probably easily adjusted for ARM64. >>>> >>>> All of this means that Device Tree support for this driver can't be >>>> merged now and effort for mainlining 5433 may be unfortunately wasted... >>> >>> Exynos5433 support is being incrementally merged (clocks, drm, phy, >>> pinctrl, thermal and tty support is already in upstream or -next). >>> >>> I don't know why DTS changes got stuck in Kukjin's tree (Kukjin, >>> could you please explain?) but I think that this shouldn't not stop >>> us from continuing Exynos5433 upstreaming effort. >> >> I already explained. There is no DTS, so the pull request was rejected >> (pull request for v4.0 I believe). >> > + Chanwoo Choi > > Yes right, as Krzysztof commented, the pull-request has been rejected by > arm-soc even I explained it has been tested on smdk5433, because it will > not be compiled without relevant board DT file. And I've rebased when > new -rc1 released until 4.3...because Chanwoo said at that time that > regarding DT file will be submitted but not yet... > > To be honest, I'm not sure I can keep the exynos5433 changes for v4.4 in > my tree at this moment... Thanks for your handling the exynos5433 patches on your tree. But, I might not send the board DTS file for Exynos5433 SoC right now. If I send the board DTS patches in the future, I'll send both board dts patches and Exynos5433 SoC patches again. Best Regards, Chanwoo Choi -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
