On Tue, May 19, 2015 at 6:08 PM, Sakari Ailus <sakari.ailus@xxxxxx> wrote: > > @@ -2557,18 +2553,27 @@ static int isp_probe(struct platform_device *pdev) > if (ret < 0) > goto error_iommu; > > - isp->notifier.bound = isp_subdev_notifier_bound; > - isp->notifier.complete = isp_subdev_notifier_complete; > - > ret = isp_register_entities(isp); > if (ret < 0) > goto error_modules; > > + if (IS_ENABLED(CONFIG_OF) && pdev->dev.of_node) { So I have a question (for Laurent, I guess) that's unrelated to this patch. Why is the "IS_ENABLED(CONFIG_OF)" important? If CONFIG_OF is disabled, isn't pdev->dev.of_node always NULL anyway? -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html