Hi Timur,
On Wednesday 15 July 2015 16:04:01 Timur Tabi wrote:
> On Tue, May 19, 2015 at 6:08 PM, Sakari Ailus <sakari.ailus@xxxxxx> wrote:
> > @@ -2557,18 +2553,27 @@ static int isp_probe(struct platform_device *pdev)
> > if (ret < 0)
> > goto error_iommu;
> >
> > - isp->notifier.bound = isp_subdev_notifier_bound;
> > - isp->notifier.complete = isp_subdev_notifier_complete;
> > -
> > ret = isp_register_entities(isp);
> > if (ret < 0)
> > goto error_modules;
> >
> > + if (IS_ENABLED(CONFIG_OF) && pdev->dev.of_node) {
>
> So I have a question (for Laurent, I guess) that's unrelated to this patch.
>
> Why is the "IS_ENABLED(CONFIG_OF)" important? If CONFIG_OF is
> disabled, isn't pdev->dev.of_node always NULL anyway?
IS_ENABLED(CONFIG_OF) can be evaluated at compile time, so it will allow the
compiler to remove the code block completely when OF support is disabled.
pdev->dev.of_node is a runtime-only check which would allow the same
optimization.
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
