Hi Laurent, On Wed, May 20, 2015 at 10:14:53AM +0300, Laurent Pinchart wrote: > On Wednesday 20 May 2015 09:57:33 Laurent Pinchart wrote: > > On Wednesday 20 May 2015 01:41:43 Sebastian Reichel wrote: > > > On Wed, May 20, 2015 at 02:08:05AM +0300, Sakari Ailus wrote: > > > > The async notifier was registered before the v4l2_device was registered > > > > and before the notifier callbacks were set. This could lead to missing > > > > the bound() and complete() callbacks and to attempting to spin_lock() > > > > and uninitialised spin lock. > > > > > > > > Also fix unregistering the async notifier in the case of an error --- > > > > the function may not fail anymore after the notifier is registered. > > > > > > > > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxx> > > > > > > I already noticed this during my Camera for N900 work and solved it > > > the same way, so: > > > > > > Reviewed-By: Sebastian Reichel <sre@xxxxxxxxxx> > > > > > > You may want to add a Fixes Tag against the patch implementing the > > > async notifier support in omap3isp, since its quite easy to run into > > > the callback problems (at least I did) and the missing resource > > > freeing (due to EPROBE_AGAIN). > > > > Applied to my tree with the Reviewed-by and Fixes tags. > > I spoke too soon. I think you forgot to remove the > v4l2_async_notifier_unregister() call from isp_register_entities(). I can fix > while applying if you agree with the change. Please do. Thanks! -- Sakari Ailus e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
