Em Wed, 24 Sep 2014 16:38:02 +0300 Antti Palosaari <crope@xxxxxx> escreveu: > > > On 09/24/2014 04:34 PM, Mauro Carvalho Chehab wrote: > > Em Wed, 24 Sep 2014 21:27:57 +0900 > > Akihiro TSUKADA <tskd08@xxxxxxxxx> escreveu: > > > >>> - b = (((s64) freq) << 20) / state->cfg.xtal_freq - (((s64) a) << 20); > >>> + b = (s32)div64_s64(((s64) freq) << 20, > >>> + state->cfg.xtal_freq - (((s64) a) << 20)); > >>> + > >> > >> I'm afraid it should be like the following. > >>> + b = (s32)(div64_s64(((s64) freq) << 20, state->cfg.xtal_freq) > >>> + - (((s64) a) << 20)); > > > > Are you talking about coding style? > > It is calculation order of operators. '/' vs. '-' Dah... -ETOOMUCHPARENTHESIS :) Fix sent. I'll likely merge it with the original patch when submitting upstream. Thanks, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
