Em Wed, 24 Sep 2014 21:27:57 +0900 Akihiro TSUKADA <tskd08@xxxxxxxxx> escreveu: > > - b = (((s64) freq) << 20) / state->cfg.xtal_freq - (((s64) a) << 20); > > + b = (s32)div64_s64(((s64) freq) << 20, > > + state->cfg.xtal_freq - (((s64) a) << 20)); > > + > > I'm afraid it should be like the following. > > + b = (s32)(div64_s64(((s64) freq) << 20, state->cfg.xtal_freq) > > + - (((s64) a) << 20)); Are you talking about coding style? Instead of using something like: var = foo_func(a, c - b); We generally use: var = foo_func(a, c - b); As it is quicker for reviewers to read. > > regads, > akihiro > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
