Hello Sachin, On 2014년 03월 06일 12:28, Sachin Kamat wrote: > Hi Seung-Woo, > > On 6 March 2014 07:43, Seung-Woo Kim <sw0312.kim@xxxxxxxxxxx> wrote: >> Hello Sachin, >> >> On 2014년 03월 05일 20:42, Sachin Kamat wrote: >>> On 5 March 2014 16:38, Seung-Woo Kim <sw0312.kim@xxxxxxxxxxx> wrote: >> >> (...) >> >>>> - dev->bank1 = dev->bank1; >>> >>> Are you sure this isn't some kind of typo? If not then your commit >>> description is too verbose >>> to actually say that the code is redundant and could be removed. The >>> code here is something like >>> >>> a = a; >>> >>> which does not make sense nor add any value and hence redundant and >>> could be removed. >> >> Right, this meaningless code can be simply removed as like the first >> version. Anyway this redundant made from change of address type in >> earlier patch. So I tried to describe that. > > What Kamil meant was that it is not a good practice to leave the > commit description > blank however trivial the patch might be. So a single line stating the > obvious should > be sufficient in this case. > Ok, I will re-send with just simple statement. Thanks, - Seung-Woo Kim -- Seung-Woo Kim Samsung Software R&D Center -- -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
