On 5 March 2014 16:38, Seung-Woo Kim <sw0312.kim@xxxxxxxxxxx> wrote: > There was assignment of memory bank with dma address converted > from physical address. But allocation has been changed with dma > function, so the assignment is not necessary. > > Signed-off-by: Seung-Woo Kim <sw0312.kim@xxxxxxxxxxx> > --- > change from v1 > - fixes subject and adds proper description > --- > drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c b/drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c > index 2475a3c..ee05f2d 100644 > --- a/drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c > +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c > @@ -44,8 +44,6 @@ int s5p_mfc_alloc_firmware(struct s5p_mfc_dev *dev) > return -ENOMEM; > } > > - dev->bank1 = dev->bank1; Are you sure this isn't some kind of typo? If not then your commit description is too verbose to actually say that the code is redundant and could be removed. The code here is something like a = a; which does not make sense nor add any value and hence redundant and could be removed. -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
