Re: [PATCH] [media] s5-mfc: remove meaningless memory bank assignment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Sachin,

On 2014년 03월 05일 20:42, Sachin Kamat wrote:
> On 5 March 2014 16:38, Seung-Woo Kim <sw0312.kim@xxxxxxxxxxx> wrote:

(...)

>> -       dev->bank1 = dev->bank1;
> 
> Are you sure this isn't some kind of typo? If not then your commit
> description is too verbose
> to actually say that the code is redundant and could be removed. The
> code here is something like
> 
>  a = a;
> 
> which does not make sense nor add any value and hence redundant and
> could be removed.

Right, this meaningless code can be simply removed as like the first
version. Anyway this redundant made from change of address type in
earlier patch. So I tried to describe that.

Regards,
- Seung-Woo Kim

-- 
Seung-Woo Kim
Samsung Software R&D Center
--

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux