Hi, Guennadi >-----Original Message----- >From: Guennadi Liakhovetski [mailto:g.liakhovetski@xxxxxx] >Sent: Wednesday, 06 March, 2013 23:00 >To: Albert Wang >Cc: corbet@xxxxxxx; linux-media@xxxxxxxxxxxxxxx; Libin Yang >Subject: RE: [REVIEW PATCH V4 02/12] [media] marvell-ccic: add clock tree support for >marvell-ccic driver > >Hi Albert > >On Wed, 6 Mar 2013, Albert Wang wrote: > >> Hi, Guennadi >> >> >> >-----Original Message----- >> >From: Guennadi Liakhovetski [mailto:g.liakhovetski@xxxxxx] >> >Sent: Tuesday, 05 March, 2013 17:51 >> >To: Albert Wang >> >Cc: corbet@xxxxxxx; linux-media@xxxxxxxxxxxxxxx; Libin Yang >> >Subject: Re: [REVIEW PATCH V4 02/12] [media] marvell-ccic: add clock tree support >for >> >marvell-ccic driver > >[snip] > >> >> @@ -331,6 +374,10 @@ static int mmpcam_probe(struct platform_device *pdev) >> >> ret = -ENODEV; >> >> goto out_unmap1; >> >> } >> >> + >> >> + ret = mcam_init_clk(mcam, pdata); >> >> + if (ret) >> >> + goto out_unmap2; >> > >> >Now, I'm confused again: doesn't this mean, that all existing users of >> >this driver will fail? >> > >> Sorry, I don't understand what's your concern? > >I mean - wouldn't the above function fail for all existing users, because >they don't provide the clocks, that you're requesting here? > OK, I see. We will update it. >Thanks >Guennadi >--- >Guennadi Liakhovetski, Ph.D. >Freelance Open-Source Software Developer >http://www.open-technology.de/ Thanks Albert Wang 86-21-61092656 -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
