Am 19.02.2013 19:53, schrieb Mauro Carvalho Chehab: > Em Tue, 19 Feb 2013 19:45:29 +0100 > Frank Schäfer <fschaefer.oss@xxxxxxxxxxxxxx> escreveu: > >>> I don't like the idea of merging those two entries. As far as I remember >>> there are devices that works out of the box with >>> EM2860_BOARD_SAA711X_REFERENCE_DESIGN. A change like that can break >>> the driver for them. >> As described above, there is a good chance to break devices with both >> solutions. >> >> What's your suggestion ? ;-) >> > As I said, just leave it as-is (documenting at web) That seems to be indeed the only 100%-regression-safe solution. But also _no_ solution for this device. A device which works only with a special module parameter passed on driver loading isn't much better than an unsupported device. It comes down to the following question: Do we want to refuse fixing known/existing devices for the sake of avoiding regression for unknown devices which even might not exist ? ;-) I have no strong and final opinion yet. Still hoping someone knows how the Empia driver handles these cases... > or to use the AC97 > chip ID as a hint. This works fine for devices that don't come with > Empiatech em202, but with something else, like the case of the Realtek > chip found on this device. The reference design for sure uses em202. How could the AC97 chip ID help us in this situation ? As far as I understand, it doesn't matter which AC97 IC is used. They are all compatible and at least our driver uses the same code for all of them. So even if you are are right and the Empia reference design uses an EMP202, EM2860_BOARD_SAA711X_REFERENCE_DESIGN might work for devices with other AC97-ICs, too. We should also expect manufacturers to switch between them whenever they want (e.g. because of price changes). Regards, Frank -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
