On Fri, Jun 22, 2012 at 11:55 AM, Mack Stanley <mcs1937@xxxxxxxxx> wrote: > So, keeping all of the configuration settings exactly the same and > simply using s5h1411_attach instead of s5h1409_attach works perfectly. > Maybe the easiest path is just to have the driver try one, if it fails, > try the other. I actually don't have a sample of the new board, so if you wanted to submit a patch upstream which does the following, that would be great: 1. in cx88-dvb.c, do the dvb_attach() call against the s5h1409 just as it was before 2. If the dvb_attach() call returns NULL for the 1409, make the attach call against the s5h1411. Submit it to the linux-media mailing list to to solicit people willing to test. This is mostly to make sure that it doesn't break the 1409 based boards. By doing the 1409 attach first, there is a high likelihood that it won't cause a regression (if you did the 1411 attach first, there is greater risk that you will cause breakage for the 1409 boards). Be sure to include the "Signed-Off-By" line which is a requirement for it to be accepted upstream. I'll eyeball the patch and put a "Reviewed-by" line on it. Devin -- Devin J. Heitmueller - Kernel Labs http://www.kernellabs.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
