On Sat, 05 May 2012 16:59:30 +0200 Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > Unless there is another good reason for doing the probing in sd_init I prefer > > to move it to sd_config. > > Sensor probing does more then just sensor probing, it also configures > things like the i2c clockrate, and if the bus between bridge and sensor > is spi / i2c or 3-wire, or whatever ... > > After a suspend resume all bets are of wrt bridge state, so we prefer to > always do a full re-init as we do on initial probe, so that we (hopefully) > will put the bridge back in a sane state. > > I think moving the probing from init to config is a bad idea, the chance > that we will get regressions (after a suspend/resume) from this are too > big IMHO. Moving the sensor probing to sd_config is normally safe because the init sequences which are sent actually after probing do all the re-initialization job. An easy way to know it in zc3xx is to force the sensor via the module parameter. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
