On Sat, 05 May 2012 17:05:28 +0200 Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > Now I see that we are doing exactly that in for example vidioc_g_jpegcomp in gspca.c, so > > we should stop doing that. We can make vidioc_g/s_jpegcomp only do the usb locking if > > gspca_dev->vdev.ctrl_handler == NULL, and once all sub drivers are converted simply remove > > it. Actually I'm thinking about making the jpegqual control part of the gspca_dev struct > > itself and move all handling of vidioc_g/s_jpegcomp out of the sub drivers and into > > the core. > > Here is an updated version of this patch implementing this approach for > vidioc_g/s_jpegcomp. We may need to do something similar in other places, although I cannot > think of any such places atm, As the JPEG parameters have been redefined as standard controls, and as there should be only a very few applications which use it, I think the vidioc_g/s_jpegcomp code could be fully removed. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
