Re: [PATCH v2] add support for DeLOCK-USB-2.0-DVB-T-Receiver-61744

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



la 5.5.2012 19:01 Thomas Mair kirjoitti:
> I am currently finishing up the work at the demod driver and will
> probably send a new version to the list tomorrow.

Nice! I will try to review it on Monday...
I looked quickly your old patch last week and tuner driver was done by
Hans-Frieder Vogt. I think he should send tuner patch first and then your
rtl2832 applied top of that.

> As I don't own a device with a different tuner than the fc0012 I will
> include an error message about the unsupported tuner and print its
> type. So It is easier to get the information about the tuners.

Sounds good.

> Right now I am writing the signal_strength callback and stumbled upon
> the following problem:
> The signal strength is read from the fc0012 tuner (only for fc0012).
> How should the driver implement this situation. Is there a callback I
> could implement within the tuner or should I just read the tuner
> registers from the demodulator?

Demod should report signal strength, normally based IF AGC. But that
estimation is very poor, tuner could report it more accurate.

On optimal situation you should implement demod callback for signal
strength and if there is tuner callback then override demod callback in
order to get better reports. IMHO that override should be done in DVB-USB
driver, in that case dvb-usb-rtl2832u. So when you attach rtl2832u just
after that override demod callback with tuner.

regards
Antti

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux