On Sun, 01 Apr 2012 19:20:21 +0300 Antti Palosaari <crope@xxxxxx> wrote: > On 01.04.2012 19:15, Michael Büsch wrote: > > On Sun, 1 Apr 2012 15:11:53 +0200 > > Michael Büsch<m@xxxxxxx> wrote: > > > >> [ 3101.940765] i2c i2c-8: Failed to read VCO calibration value (got 20) > > > > Ok, it turns out that it doesn't fail all the time, but only sporadically. > > So increasing the number of retries fixes (or at least works around) it. > > OK, feel free to add ~3 retries inside af9035_ctrl_msg() i think. Well I didn't retry at that level, but at the fc0011 driver level. It does already retry once in fc0011 (with complete tuner reset). I increased it to 6 times (3 was not enough). I think we can't retry at af9035_ctrl_msg() level, because the actual i2c/usb transfer does not fail. The received packet checksum even is ok (although we currently don't check it. I'll send a patch for that later). > You didn't mention if error is coming from af9035 firmware or from USB > stack. Just for the interest... I don't know how much the firmware is involved in this, but _maybe_ this glitch is caused by it. -- Greetings, Michael. PGP encryption is encouraged / 908D8B0E
Attachment:
signature.asc
Description: PGP signature