Am Sonntag, 1. April 2012 schrieb Michael Büsch:
> On Sun, 1 Apr 2012 16:42:34 +0200
>
> "Hans-Frieder Vogt" <hfvogt@xxxxxxx> wrote:
> > > [ 3101.940765] i2c i2c-8: Failed to read VCO calibration value (got 20)
> > >
> > > It doesn't run into this check on the other af903x driver.
> > > So I suspect an i2c read issue here.
> >
> > I would first uncomment the i2c read functionality in Antti's driver!
>
> I did this.
sorry. I didn't check your patches. However, I found the problem: the buffer
length needs to be msg[1].len, see below. For my mxl5007t based device it
worked.
--- old/af9035.c 2012-04-01 16:41:53.694103691 +0200
+++ new/af9035.c 2012-04-01 18:22:25.026930784 +0200
@@ -209,24 +209,15 @@
msg[1].len);
} else {
/* I2C */
-#if 0
- /*
- * FIXME: Keep that code. It should work but as it is
- * not tested I left it disabled and return -
EOPNOTSUPP
- * for the sure.
- */
u8 buf[4 + msg[0].len];
struct usb_req req = { CMD_I2C_RD, 0, sizeof(buf),
buf, msg[1].len, msg[1].buf };
- buf[0] = msg[0].len;
+ buf[0] = msg[1].len;
buf[1] = msg[0].addr << 1;
buf[2] = 0x01;
buf[3] = 0x00;
memcpy(&buf[4], msg[0].buf, msg[0].len);
ret = af9035_ctrl_msg(d->udev, &req);
-#endif
- pr_debug("%s: I2C operation not supported\n",
__func__);
- ret = -EOPNOTSUPP;
}
} else if (num == 1 && !(msg[0].flags & I2C_M_RD)) {
if (msg[0].len > 40) {
> > > Attached: The patches.
>
> See the patches.
cheers,
Hans-Frieder Vogt e-mail: hfvogt <at> gmx .dot. net
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
