Hi Laurent,
Thanks for the comments.
On Wed, Mar 07, 2012 at 12:00:48PM +0100, Laurent Pinchart wrote:
> On Tuesday 06 March 2012 18:33:11 Sakari Ailus wrote:
> > Perform CCDC link validation in ccdc_link_validate() instead of
> > isp_video_validate_pipeline(). Also perform maximum data rate check in
> > isp_video_check_external_subdevs().
> >
> > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxx>
>
> [snip]
>
> > diff --git a/drivers/media/video/omap3isp/ispvideo.c
> > b/drivers/media/video/omap3isp/ispvideo.c index 6d4ad87..51075b3 100644
> > --- a/drivers/media/video/omap3isp/ispvideo.c
> > +++ b/drivers/media/video/omap3isp/ispvideo.c
>
> [snip]
>
> > @@ -950,6 +867,7 @@ static int isp_video_check_external_subdevs(struct
> > isp_pipeline *pipe) struct v4l2_subdev_format fmt;
> > struct v4l2_ext_controls ctrls;
> > struct v4l2_ext_control ctrl;
> > + unsigned int rate = UINT_MAX;
>
> You can move this variable inside the if statement below.
Fixed.
> > int i;
> > int ret = 0;
> >
> > @@ -1002,6 +920,16 @@ static int isp_video_check_external_subdevs(struct
> > isp_pipeline *pipe)
> >
> > pipe->external_rate = ctrl.value64;
> >
> > + if (pipe->entities & (1 << isp->isp_ccdc.subdev.entity.id)) {
> > + /*
> > + * Check that maximum allowed CCDC pixel rate isn't
> > + * exceeded by the pixel rate.
>
> What's wrong with 80 columns, really ? :-)
Is it said somewhere in CodingStyle the comments have to be wrapped at 80
characters and no earlier? It's like speed limits: you are allowed to drive
slower than the limit. :-)
> > + */
> > + omap3isp_ccdc_max_rate(&isp->isp_ccdc, &rate);
> > + if (pipe->external_rate > rate)
> > + return -ENOSPC;
> > + }
> > +
> > return 0;
> > }
>
> Pending those two changes,
>
> Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
Thanks. :-)
Cheers,
--
Sakari Ailus
e-mail: sakari.ailus@xxxxxx jabber/XMPP/Gmail: sailus@xxxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
